remove wait in all_to_all_single custom op #2646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64666999 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Dec 19, 2024
Summary: # context * remove the `torch.ops._c10d_functional.wait_tensor` call in all_to_all_single. * use `autograd.function` implementation to create a `AllToAllSingle` function * There is a wait_tensor after the all_to_all_single call: pytorch/pytorch#143533 Differential Revision: D64666999
TroyGarden
force-pushed
the
export-D64666999
branch
from
872080e to
4529733
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64666999 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Dec 19, 2024
Summary: # context * remove the `torch.ops._c10d_functional.wait_tensor` call in all_to_all_single. * use `autograd.function` implementation to create a `AllToAllSingle` function * There is a wait_tensor after the all_to_all_single call: pytorch/pytorch#143533 Differential Revision: D64666999
TroyGarden
force-pushed
the
export-D64666999
branch
from
4529733 to
c7a0498
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64666999 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Dec 19, 2024
Summary: # context * remove the `torch.ops._c10d_functional.wait_tensor` call in all_to_all_single. * use `autograd.function` implementation to create a `AllToAllSingle` function * There is a wait_tensor after the all_to_all_single call: pytorch/pytorch#143533 Differential Revision: D64666999
TroyGarden
force-pushed
the
export-D64666999
branch
from
c7a0498 to
dd1fcdb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64666999 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Dec 19, 2024
Summary: # context * remove the `torch.ops._c10d_functional.wait_tensor` call in all_to_all_single. * use `autograd.function` implementation to create a `AllToAllSingle` function * There is a wait_tensor after the all_to_all_single call: pytorch/pytorch#143533 Reviewed By: IvanKobzarev Differential Revision: D64666999
TroyGarden
force-pushed
the
export-D64666999
branch
from
dd1fcdb to
ac892db
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64666999 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D64666999 |
Summary: # context * remove the `torch.ops._c10d_functional.wait_tensor` call in all_to_all_single. * use `autograd.function` implementation to create a `AllToAllSingle` function * There is a wait_tensor after the all_to_all_single call: pytorch/pytorch#143533 Reviewed By: IvanKobzarev Differential Revision: D64666999
TroyGarden
force-pushed
the
export-D64666999
branch
from
ac892db to
d041de1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64666999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
torch.ops._c10d_functional.wait_tensorcall in all_to_all_single.autograd.functionimplementation to create aAllToAllSinglefunctionDifferential Revision: D64666999